parallelize creation of file history cache for individual files #3636
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
June 15, 2021 15:35
ahornace
reviewed
Jun 15, 2021
opengrok-indexer/src/main/java/org/opengrok/indexer/history/FileHistoryCache.java
Outdated
Show resolved
Hide resolved
|
Nice work! Looks good besides the failing test. |
The failing test is actually a problem. Given that |
added 12 commits
June 15, 2021 17:48
ahornace
approved these changes
Jun 16, 2021
opengrok-indexer/src/main/java/org/opengrok/indexer/history/FileHistoryCache.java
Show resolved
Hide resolved
opengrok-indexer/src/main/java/org/opengrok/indexer/history/History.java
Show resolved
Hide resolved
opengrok-indexer/src/main/java/org/opengrok/indexer/history/History.java
Outdated
Show resolved
Hide resolved
opengrok-indexer/src/test/java/org/opengrok/indexer/history/HistoryTest.java
Outdated
Show resolved
Hide resolved
opengrok-indexer/src/main/java/org/opengrok/indexer/history/History.java
Show resolved
Hide resolved
|
After measuring the history cache runs I can no longer see the dramatic speedup (or rather the
|
|
Checked that the tags are displayed normally in the UI after recreating the history cache from scratch. |
This was referenced Jun 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change parallelizes the creation of file history cache for individual files, mimicking what is already done for renamed files.
On my laptop with i7-8665U (4 cores) and built in SSD I am seeing some decent speedup (6 vs 9 minutes) when creating history cache for the OpenSSL Git repository (renamed files on, merge commits on).
There is some potential for further speedup - the directories are still created sequentially and the process should avoid duplications.