Fix another batch of Sonar-identified issues #3148
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
idodeclare
commented
May 9, 2020
idodeclare
commented
- Sanitize several user-supplied strings.
- Fix some scope issues.
- Prohibit XML external access.
- Sanitize several user-supplied strings. - Fix some scope issues. - Prohibit XML external access.
vladak
reviewed
May 11, 2020
| @@ -561,7 +554,6 @@ private void findFilelessChildren(SkeletonDirs skels, File directory) { | |||
|
|
|||
| /** | |||
| * Counts segments arising from {@code File.separatorChar} or '\\'. | |||
| * @param path | |||
There was a problem hiding this comment.
Restored with a comment
vladak
reviewed
May 11, 2020
| if (value == null) { | ||
| return null; | ||
| } | ||
| return value.replaceAll("[\\n\\r\\t\\f]", "_"); |
There was a problem hiding this comment.
also, userInput() and luceneQuery() can be refactored into using common underlying method ?
vladak
reviewed
May 11, 2020
|
|
||
| HashMap<String, String[]> safes = new HashMap<>(); | ||
| for (Map.Entry<String, String[]> entry : map.entrySet()) { | ||
| String k = logging(entry.getKey()); |
There was a problem hiding this comment.
Suggested change
| String k = logging(entry.getKey()); | |
| String key = logging(entry.getKey()); |
vladak
reviewed
May 11, 2020
| * Represents a container for sanitizing methods for avoiding classifications as | ||
| * taint bugs. | ||
| */ | ||
| public class LaunderUtil { |
There was a problem hiding this comment.
perhaps this class should be called Laundromat and have the launder as a method ? :-)
|
I could argue about naming of Laundromat and its methods, but I guess I'll just keep smiling |
|
Thank you for taking a look, Lubos 😁 |
|
merging |
|
Thank you, Lubos |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.