Feature/retire lex helpers #2652
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tulinkry
reviewed
Feb 1, 2019
opengrok-indexer/src/main/java/org/opengrok/indexer/analysis/perl/PerlLexer.java
Outdated
Show resolved
Hide resolved
opengrok-indexer/src/main/java/org/opengrok/indexer/analysis/ruby/RubyLexer.java
Outdated
Show resolved
Hide resolved
opengrok-indexer/src/main/java/org/opengrok/indexer/analysis/perl/PerlLexer.java
Outdated
Show resolved
Hide resolved
opengrok-indexer/src/main/java/org/opengrok/indexer/analysis/ruby/RubyLexer.java
Outdated
Show resolved
Hide resolved
idodeclare
force-pushed
the
feature/retire_lex_helpers
branch
3 times, most recently
from
9c49f7f to
e3da707
Compare
tarzanek
reviewed
Feb 8, 2019
| @@ -122,6 +103,66 @@ import org.opengrok.indexer.web.HtmlConsts; | |||
| } | |||
|
|
|||
| protected void skipLink(String s, Pattern p) { /* noop */ } | |||
|
|
|||
| /** | |||
There was a problem hiding this comment.
where are below functions used?
There was a problem hiding this comment.
They’re called by the abstract PerlLexer extended by the Perl JFlex xref and symtok classes. Formerly the values were injected through the helper delegate constructor but now can be mediated through method overrides.
Missed a few because they were in-flight with enhancements -- or just plain missed, as with PlainSymbolTokenizer.
idodeclare
force-pushed
the
feature/retire_lex_helpers
branch
from
e3da707 to
3b46bc3
Compare
|
ok, let's merge, thank you! |
|
hopefully this didn't conflict with #2673 (resp. I hope vertilog didn't use these helpers ;-) ) @idodeclare Chris? |
|
No — all good, @tarzanek. Thank you, Lubos. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Please consider for integration this refactoring I finally got around to do after having unified the class hierarchy for xrefers and symbol tokenizers a while ago in 80ef15e.
The delegates I previously used in order to have common JFlex specifications for xref/symtok for Perl, Ruby, Ada, and Eiffel can now be subsumed as language-specific, common xref/symtok base classes (which was the intention of 80ef15e).
This way any interested parties who want to write analyzers don't have to concern themselves with the delegate pattern previously required when a common JFlex spec was desired (and which should be desired for analyzers going forward).
Additionally I caught a few places where single-char identifiers were not revised to be actively linked as was done for all other languages a year ago.
Thank you.