Skip to content

improving performance of project picker filter #1237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 18, 2016

Conversation

tulinkry
Copy link
Contributor

Fixed by replacing the recursion with simple iteration and all not necessary calls to jquery are replaced with some kind of counter.

Also a timeout for the search is introduced, so that the search does not fire after every key press immediately (for example when user is typing more letters). By default to 300ms.

The speedup is nice, tested on ~1000 repositories and 200 groups. The input was 595 for which there is only one result in one group.
Old setup:

searching: timer started
searching: 876.03ms
searching: timer started
searching: 1065.39ms
searching: timer started
searching: 1067.71ms

New setup (without the timeout):

searching: timer started
searching: 53.42ms
searching: timer started
searching: 150.53ms
searching: timer started
searching: 163.55ms

@vladak
Copy link
Member

vladak commented Oct 14, 2016

Tested on the same setup as this was reported in the issue, it is subjectively significantly faster so that it can be considered generally usable.

@tulinkry tulinkry added this to the 0.13 milestone Oct 14, 2016
@tulinkry tulinkry self-assigned this Oct 14, 2016
@tarzanek
Copy link
Contributor

@tulinkry can you pls resolve conflicts?

@tulinkry tulinkry force-pushed the project-picker-performance branch from 81e7b34 to b9fe3a5 Compare October 17, 2016 12:30
@tulinkry
Copy link
Contributor Author

resolved

@vladak
Copy link
Member

vladak commented Oct 18, 2016

Could you try contributing at least some of these changes to upstream ? This would make maintenance easier.

@vladak vladak merged commit 061639f into oracle:master Oct 18, 2016
@tulinkry tulinkry deleted the project-picker-performance branch October 27, 2016 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants