making tablesorter size parser more robust #1234
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladak
requested changes
Oct 14, 2016
| var num = parts[1]; | ||
| /* | ||
| * This correctly handles thousand separator | ||
| * in a big number (either ',' or ' ' or none) |
There was a problem hiding this comment.
I'd maybe add bunch of concrete examples.
| * This correctly handles thousand separator | ||
| * in a big number (either ',' or ' ' or none) | ||
| */ | ||
| var parts = s.match(/^((?:\d{1,3}(?:[, ]?\d{1,3})*(?:\.\d+)?|\.\d+)) ?(\w*)$/); |
There was a problem hiding this comment.
Seems like there is extra paren level ?
((?:\d{1,3}(?:[, ]?\d{1,3})*(?:\.\d+)?|\.\d+))
^^ ^^
|
Pls also create new issue to get this tested (#1233). |
tulinkry
force-pushed
the
tablesorter-fix
branch
from
fdb974a to
96b9d8e
Compare
|
Issue #1238 |
vladak
approved these changes
Oct 18, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1221