Add model docs and links to model docs, Add return types, Fixup format #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tting Signed-off-by: Garth Bushell <garth@garthy.com>
priteshkp
requested review from
briangustafson,
jodoglevy and
numberoverzero
numberoverzero
approved these changes
Feb 17, 2017
numberoverzero
left a comment
numberoverzero
left a comment
There was a problem hiding this comment.
Looks great! Thanks for adding rtype to everything!
briangustafson
approved these changes
Mar 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix formatting in some param:
Add Model docs
Add Client Method return types
Signed-off-by: Garth Bushell garth@garthy.com