Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added OCI MLFlow Auth Plugin #21

Merged
merged 10 commits into from
Nov 2, 2023
Merged

Added OCI MLFlow Auth Plugin #21

merged 10 commits into from
Nov 2, 2023

Conversation

lu-ohai
Copy link
Member

@lu-ohai lu-ohai commented Sep 19, 2023

Added OCI MLFlow Auth Plugin

  • Support auth type:
    -- resource_principal
    -- instance_principal
    -- api_key
    -- security_token
    -- Any empty or invalid auth type will be treated as api_key by default

User Experience

  1. Install oci-mlflow plugin to let RequestAuthProvider registered
  2. Set environment variable to inject auth signer to http request
  • key: MLFLOW_TRACKING_AUTH
  • value: OCI_REQUEST_AUTH
os.environ["MLFLOW_TRACKING_AUTH"] = "OCI_REQUEST_AUTH"

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Sep 19, 2023
@github-actions
Copy link

📌 Overall coverage:

No success to gather report. 😿

@github-actions
Copy link

📌 Overall coverage:

Coverage-31.96%

@github-actions
Copy link

📌 Overall coverage:

No success to gather report. 😿

@lu-ohai
Copy link
Member Author

lu-ohai commented Sep 19, 2023 •
edited
Loading

MLFlow SDK with support to customize auth has been released: https://github.com/mlflow/mlflow/releases/tag/v2.8.0

@github-actions
Copy link

📌 Overall coverage:

No success to gather report. 😿

1 similar comment
@github-actions
Copy link

📌 Overall coverage:

No success to gather report. 😿

@github-actions
Copy link

📌 Overall coverage:

Coverage-89.39%

@mayoor
Copy link
Member

mayoor commented Oct 30, 2023

Couple of things -

  • Can we use ads.auth.default_signer to get rid of the if/else statements around what signer to create?
  • Since auth plugin is supported only in mlflow 2.8 and above, we need to update the dependency here -

    oci-mlflow/pyproject.toml

    Line 52 in 2c45f87

    "mlflow>=2.3.2",

@github-actions
Copy link

📌 Overall coverage:

No success to gather report. 😿

1 similar comment
@github-actions
Copy link

📌 Overall coverage:

No success to gather report. 😿

@github-actions
Copy link

📌 Overall coverage:

Coverage-89.02%

@github-actions
Copy link

📌 Overall coverage:

Coverage-90.29%

@github-actions
Copy link

📌 Overall coverage:

No success to gather report. 😿

1 similar comment
@github-actions
Copy link

📌 Overall coverage:

No success to gather report. 😿

@lu-ohai
Copy link
Member Author

lu-ohai commented Oct 30, 2023

Couple of things -

* Can we use ads.auth.default_signer to get rid of the if/else statements around what signer to create?

* Since auth plugin is supported only in mlflow 2.8 and above, we need to update the dependency here - https://github.com/oracle/oci-mlflow/blob/2c45f8763d4a982fbf4363ea2115b501afbcc91e/pyproject.toml#L52

Thanks, this makes it way easier! Just updated the code 😄

mayoor
mayoor previously approved these changes Nov 2, 2023
View reviewed changes
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 2, 2023

📌 Overall coverage:

No success to gather report. 😿

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 2, 2023

📌 Overall coverage:

Coverage-90.29%

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 2, 2023

📌 Overall coverage:

No success to gather report. 😿

@lu-ohai lu-ohai merged commit 6753d39 into main Nov 2, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrDzurb mrDzurb mrDzurb approved these changes

@mayoor mayoor mayoor left review comments

@qiuosier qiuosier Awaiting requested review from qiuosier

Assignees
No one assigned
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lu-ohai @mayoor @mrDzurb