Skip to content

Bug Fix: infinite Loop #1783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
willianmarquess wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Bug Fix: infinite Loop #1783

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
289b2ac
fix: infinity loop
willianmarquess Jul 16, 2026
c2f45d7
Merge branch 'oracle:main' into main
willianmarquess Jul 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions lib/thin/pool.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -481,7 +481,7 @@ class ThinPoolImpl extends PoolImpl {
}

// if no pending requests, wait for pending requests to appear!
if ((this._pendingRequests.length == 0 || this._bgErr) &&
if ((numToCreate <= 0 || this._bgErr) &&
this.getConnectionsOpen() >= this._poolMin) {
await new Promise((resolve) => {
this.bgWaiter = resolve;
Expand Down Expand Up @@ -613,6 +613,10 @@ class ThinPoolImpl extends PoolImpl {
if ((this.getConnectionsOpen() < this._poolMax) &&
this._shouldRetainInPool(conn)) {
this._freeConnectionList.push(conn);
if(this._pendingRequests.length > 0) {
const payload = this._pendingRequests.shift();
payload.resolve();
}
} else {
this._invokeBgCleaner(conn);
}
Expand Down Expand Up @@ -694,7 +698,7 @@ class ThinPoolImpl extends PoolImpl {
this._bgCleaner();

// ensure min connections are maintained in pool
if ((this.getConnectionsOpen() < this._poolMin) && this.bgWaiter)
if ((this.getConnectionsOpen() < this._poolMin) || this._pendingRequests.length > 0 && this.bgWaiter)
this.bgWaiter();
}

Expand Down