-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the binary module compatible with Node 0.12 & io.js 1.0.x using NaN #2
Comments
+1 |
+1 👍 |
+1 |
+1 |
2 similar comments
+1 |
+1 |
+1 |
+1 |
+1 for the io.js support. Any sense as to when you might get to this or should I stick with NodeJS for the time being? |
@cjbj Any update for this issue? |
I can't give an ETA, sorry. I notice no one has submitted a PR adding support. What should I read into that? :) |
+1 |
1 similar comment
+1 |
+1 |
6 similar comments
+1 |
+1 |
+1 |
+1 |
+1 |
+1 |
+1 |
+1 |
2 similar comments
+1 |
+1 |
NaN v1.7.0 supports node v0.12 now. Does that make any difference? |
@Bigous so the fix is on the way, as soon as its approved. Thanks! |
👍 |
3 similar comments
+1 |
+1 |
+1 |
+1 |
2 similar comments
+1 |
👍 |
We've merged #43 node-oracledb now builds with Node.js 0.10, 0.12 and also with io.js. |
NaN provides the abstraction to keep C/C++ addon code compatible with underlying V8 APIs. See: https://github.com/rvagg/nan.
As a reference, we use NaN in https://github.com/strongloop/strong-oracle.
The text was updated successfully, but these errors were encountered: