Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the binary module compatible with Node 0.12 & io.js 1.0.x using NaN #2

Closed
raymondfeng opened this issue Jan 20, 2015 · 35 comments
Closed
Assignees

Comments

@raymondfeng
Copy link

NaN provides the abstraction to keep C/C++ addon code compatible with underlying V8 APIs. See: https://github.com/rvagg/nan.

As a reference, we use NaN in https://github.com/strongloop/strong-oracle.

@cjbj cjbj self-assigned this Jan 20, 2015
@vkurchatkin
Copy link

+1

@hertzg
Copy link

hertzg commented Feb 9, 2015

+1 👍

@jeffm13
Copy link

jeffm13 commented Feb 17, 2015

+1

@Qard
Copy link

Qard commented Feb 20, 2015

+1

2 similar comments
@pkoretic
Copy link

+1

@mkozjak
Copy link

mkozjak commented Feb 26, 2015

+1

@jpiulac
Copy link

jpiulac commented Feb 27, 2015

+1

@vincemtnz
Copy link

+1

@toddhay
Copy link

toddhay commented Mar 6, 2015

+1 for the io.js support. Any sense as to when you might get to this or should I stick with NodeJS for the time being?

@hertzg
Copy link

hertzg commented Mar 7, 2015

@cjbj Any update for this issue?

@cjbj
Copy link
Member

cjbj commented Mar 7, 2015

I can't give an ETA, sorry.

I notice no one has submitted a PR adding support. What should I read into that? :)

@alexsantos
Copy link

+1

1 similar comment
@rightson
Copy link

rightson commented Mar 9, 2015

+1

@Bigous Bigous mentioned this issue Mar 10, 2015
@bjouhier
Copy link

+1

6 similar comments
@iwater
Copy link

iwater commented Mar 16, 2015

+1

@volkmarbuehringer
Copy link

+1

@MathieuClusiau
Copy link

+1

@mjhasbach
Copy link

+1

@syrinx2012
Copy link

+1

@amaruak00
Copy link

+1

@flakekun
Copy link

+1

@raviv
Copy link

raviv commented Mar 27, 2015

+1

2 similar comments
@kdclaw3
Copy link

kdclaw3 commented Mar 27, 2015

+1

@needforspeed
Copy link

+1

@haruitk
Copy link

haruitk commented Apr 16, 2015

NaN v1.7.0 supports node v0.12 now. Does that make any difference?

@Bigous
Copy link
Contributor

Bigous commented Apr 16, 2015

@haruitk look at the pull request #43

@haruitk
Copy link

haruitk commented Apr 16, 2015

@Bigous so the fix is on the way, as soon as its approved. Thanks!

@danielb2
Copy link

👍

3 similar comments
@scottchantry
Copy link

+1

@Dahriel
Copy link

Dahriel commented Apr 27, 2015

+1

@andrewbrereton
Copy link

+1

@xuxiankun
Copy link

+1

2 similar comments
@juancancela
Copy link

+1

@qfox
Copy link

qfox commented May 5, 2015

👍

@cjbj cjbj mentioned this issue May 23, 2015
@cjbj
Copy link
Member

cjbj commented May 26, 2015

We've merged #43

node-oracledb now builds with Node.js 0.10, 0.12 and also with io.js.

@cjbj cjbj closed this as completed May 26, 2015
@oracle oracle locked and limited conversation to collaborators Aug 13, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests