-
Notifications
You must be signed in to change notification settings - Fork 77
Feature/pdpdevtool 6203 merge dev with release 25.2 #952
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Parent:
merge release/25.2 into dev
davidecorreu
merged 78 commits into
release/25.2
from
feature/PDPDEVTOOL-6203_merge_dev_with_release_25.2
Oct 7, 2025
Merged
Feature/pdpdevtool 6203 merge dev with release 25.2 #952
davidecorreu
merged 78 commits into
release/25.2
from
feature/PDPDEVTOOL-6203_merge_dev_with_release_25.2
Oct 7, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
carolnavarropereira
commented
Oct 6, 2025
- Merge dev to release 25.2
- Removal of schemas
- Review versions to release
- Update base package-lock.json
merge release/25.2 into dev
This reverts commit e6f3a02.
…chemas-on-dev restore packages/schemas on dev branch
…versions feature/pdpdevtool-6106: bump dev versions
Modify versioning in dev
…etup-ci-change-default-auth-id-ci-mode PDPDEVTOOL-6172 Expand account:setup:ci to change the default auth id in ci mode
fix circular dependency NodeTranslationService - FileUtils
…resh-token-node-cli-util feature/pdpdevtool-6200: add force refresh token to node-cli AuthenticationUtils
…ets-and-terms fix brackets and terms
add devassist configuration to suitecloud.ts add import for DevAssistProxyService to ExtensionUtil.ts add skipLibCheck option to tsconfig.json
improve vscode-extension/pacakge.json configuration descriptions
fix comment grammar on DevAssistConfiguration.ts show devassist statusBar when required at startup add extra comment during devAssistStatusBar creation
refactor MessageService.ts to devassist specific logic
fix DEVASSIST_SERVICE_STARTUP_MESSAGE message
Using SuiteCloudAuthProxyService node-cli service from vscode-extension. Adding vscode settings to be able to configure Dev Assist service.
…pace-settings-fix bugfix/PDPDEVTOOL-6248-open-workspace-settings-fix
…t-license feature/pdpdevtool 6250 devassist temporary terms and conditions
add type for node-cli ConsoleLogger to avoid future mistakes
…gger-method bugfix/PDPDEVTOOL-6254: fix wrong vsLogger method call adding typing to avoid similar errors
define SuiteCloudAuthProxy as typescript class replace term Interface for Instance on JavascriptNodeCli.d.ts
…er-and-types PDPDEVTOOL-6254-fix-vslogger-and-types
…3_merge_dev_with_release_25.2 # Conflicts: # packages/node-cli/src/metadata/SdkCommandsMetadataPatch.json
davidecorreu
reviewed
Oct 7, 2025
Comment on lines
+22
to
+23
| if (actionResult.mode === REUSE) { | ||
| //SELECT mode |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't seem to be right. We should keep it in mind when we do testing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what doesn't seem right?
Please elaborate
davidecorreu
approved these changes
Oct 7, 2025
TheJorgeBorras
approved these changes
Oct 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
