-PDPDEVTOOL-5947 vscode-extension - Remove the See Details button on warnings and errors #885
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the auth warnings
oracle-contributor-agreement
bot
added
the
OCA Verified
karl-anthony-ng
suggested changes
Feb 3, 2025
| ); | ||
| } | ||
|
|
||
| showWarningMessageDismiss(warningMessage: string, includeProjectName = true) { |
There was a problem hiding this comment.
Suggest to rename it to showWarningMessageWithDismiss.
There was a problem hiding this comment.
Now is going to be Ok at the end, so showWarningMessageWithOk will do
…TOOL-5947_vscode_extension_remove_see_details_warnings_errors
davidecorreu
approved these changes
Feb 3, 2025
karl-anthony-ng
approved these changes
Feb 4, 2025
karl-anthony-ng
deleted the
bugfix/PDPDEVTOOL-5947_vscode_extension_remove_see_details_warnings_errors
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fallback warning now uses a "dismiss" instead of a see details button
M2M/BWB not allowed removed the see details button