This repository was archived by the owner on May 28, 2021. It is now read-only.
Implement MySQL version upgrade support #207
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Probably worth adding that end to end test. I will do some manual testing tomorrow. |
owainlewis
reviewed
Aug 16, 2018
| return nil | ||
| } | ||
|
|
||
| func (m *MySQLController) ensureMySQLVersion(c *v1alpha1.Cluster, ss *apps.StatefulSet) error { |
Member
There was a problem hiding this comment.
Might be worth unit testing this logic.
owainlewis
approved these changes
Aug 17, 2018
Member
owainlewis
left a comment
owainlewis
left a comment
There was a problem hiding this comment.
LGTM. I think some minimal downtime might be expected when performing this kind of operation using the router. I'm not sure if there is any way we could mitigate it TBH.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've tested the implementation and it works. It's not completely without downtime, however.
I used the Wordpress demo during testing and a script that curls the WordPress site every second. It reliably returned a single 500 error during the primary failover.
We should probably write an E2E test covering the functionality. Happy to block merge until I've done so or open an issue to follow up.
Resolves: #198