Skip to content
This repository was archived by the owner on May 28, 2021. It is now read-only.
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 10 additions & 28 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -18,19 +18,16 @@ ifdef WERCKER
TENANT := "oracle"
else
NEW_NAMESPACE ?= e2e-${USER}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No longer used

VERSION := ${USER}-$(shell date +%Y%m%d%H%M%S)
VERSION := ${USER}-$(shell git describe --always --dirty)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be ?=

TENANT := "spinnaker"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be ?=

endif

ROOT_DIR := $(shell dirname $(abspath $(lastword $(MAKEFILE_LIST))))
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No longer used

PKG := github.com/oracle/mysql-operator
REGISTRY := iad.ocir.io/$(TENANT)
REGISTRY := iad.ocir.io
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be ?=

SRC_DIRS := cmd pkg test/examples
REGISTRY_STRING := $(subst /,_,$(REGISTRY))
CMD_DIRECTORIES := $(sort $(dir $(wildcard ./cmd/*/)))
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No longer used

COMMANDS := $(CMD_DIRECTORIES:./cmd/%/=%)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No longer used

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still used / referenced. Will remove in a subsequent PR when fixing the build step to keep things clean.

CONTAINER_FILES := $(addprefix .container-$(REGISTRY_STRING)-,$(addsuffix -$(VERSION),$(COMMANDS)))
PUSH_FILES := $(addprefix .push-$(REGISTRY_STRING)-,$(addsuffix -$(VERSION),$(COMMANDS)))

ARCH := amd64
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be ?=

OS := linux
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be ?=

Expand Down Expand Up @@ -75,23 +72,15 @@ build: dist build-dirs Makefile
ARCH=$(ARCH) OS=$(OS) VERSION=$(VERSION) PKG=$(PKG) ./hack/build.sh
cp $(BINARIES) ./bin/$(OS)_$(ARCH)/

# Note: Only used for development, i.e. in CI the images are built using Wercker.
.PHONY: containers
containers: $(CONTAINER_FILES)
.container-$(REGISTRY_STRING)-%-$(VERSION): build dist
@echo Builing container: $*
@docker login -u '$(DOCKER_REGISTRY_USERNAME)' -p '$(DOCKER_REGISTRY_PASSWORD)' $(REGISTRY)
@docker build --build-arg=http_proxy --build-arg=https_proxy -t $(REGISTRY)/$*:$(VERSION) -f docker/$*/Dockerfile .
@docker images -q $(REGISTRY)/$*:$(VERSION) > $@

# Note: Only used for development, i.e. in CI the images are pushed using Wercker.
.PHONY: push
push: $(PUSH_FILES)
.push-$(REGISTRY_STRING)-%-$(VERSION): .container-$(REGISTRY_STRING)-%-$(VERSION)
@echo Pushing container: $*
@docker login -u '$(DOCKER_REGISTRY_USERNAME)' -p '$(DOCKER_REGISTRY_PASSWORD)' $(REGISTRY)
@docker push $(REGISTRY)/$*:$(VERSION)
@docker images -q $(REGISTRY)/$*:$(VERSION) > $@
push: build
@docker build --build-arg=http_proxy --build-arg=https_proxy -t $(REGISTRY)/$(TENANT)/mysql-operator:$(VERSION) -f docker/mysql-operator/Dockerfile .
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would break these up over multiple lines

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree. Split into a separate step for hygiene and broken into multiple lines.

@docker build --build-arg=http_proxy --build-arg=https_proxy -t $(REGISTRY)/$(TENANT)/mysql-agent:$(VERSION) -f docker/mysql-agent/Dockerfile .

@docker login iad.ocir.io -u $(DOCKER_REGISTRY_USERNAME) -p '$(DOCKER_REGISTRY_PASSWORD)'
@docker push $(REGISTRY)/$(TENANT)/mysql-operator:$(VERSION)
@docker push $(REGISTRY)/$(TENANT)/mysql-agent:$(VERSION)

.PHONY: version
version:
Expand All @@ -102,14 +91,7 @@ lint:
@find pkg cmd -name '*.go' | grep -v 'generated' | xargs -L 1 golint

.PHONY: clean
clean: container-clean bin-clean

.PHONY: container-clean
container-clean:
rm -rf .container-* .push-* dist

.PHONY: bin-clean
bin-clean:
clean:
rm -rf .go bin
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to rm .go as it's not created any more AFAIK

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still created on my machine. Will remove after fixing the build process in a subsequent PR.


.PHONY: run-dev
Expand Down