typos and clean up #529
typos and clean up #529
Conversation
Signed-off-by: Aurelio Garcia-Ribeyro <aurelio.garciaribeyro@oracle.com>
…tps://code.visualstudio.com/brand Signed-off-by: Aurelio Garcia-Ribeyro <aurelio.garciaribeyro@oracle.com>
oracle-contributor-agreement
bot
added
the
OCA Verified
sid-srini
left a comment
sid-srini
left a comment
There was a problem hiding this comment.
Thanks a lot @aureliogrb.
Please do check if you are intentionally removing changes on the README from the previous commit, or is it an artifact of rebasing the pull to the 25.0.0 branch. Thanks.
|
|
||
|
|
||
| ## Getting Started | ||
| 1. See the [VS Code Tips](https://github.com/oracle/javavscode/wiki/VSCode-Tips) wiki for a quick primer on getting started with VS Code. |
There was a problem hiding this comment.
Is the removal of the link to the wiki page for VS Code tips intentional or an artifact of rebasing the pull to 25.0.0?
There was a problem hiding this comment.
@arvindaprameya suggested I remove the older entries rather than trying to merge them. I have no argument against the previous entries.
There was a problem hiding this comment.
But your commits will end up reverting the changes introduced in #527. So I would request your review of the README as seen in the 25.0.0 branch. Thank you.
There was a problem hiding this comment.
@arvindaprameya / @aureliogrb / @sid-srini #530 have cherry-picked changes in this pr and added back wiki urls overriden, please take a look
|
|
||
| ## Interactive Java Notebooks | ||
| ### Introduction | ||
| * Experience interactive coding with Java notebooks. See the [Using Interactive Java Notebooks](https://github.com/oracle/javavscode/wiki/Interactive-Java-Notebooks) wiki for guidance and tutorials on using notebooks. |
There was a problem hiding this comment.
Is the removal of the link to the wiki guide for notebooks intentional or an artifact of rebasing the pull to 25.0.0?
There was a problem hiding this comment.
Same as previous, @arvindaprameya suggested overwriting rather than merging.
There was a problem hiding this comment.
Same as previous. Kindly review the README on this 25.0.0 branch and merge your changes as you see fit. Thanks
There was a problem hiding this comment.
@arvindaprameya / @aureliogrb / @sid-srini #530 have cherry-picked changes in this pr and added back wiki urls overriden, please take a look
|
Closing this PR since the original #528 has been cherry-picked and merged via #530. Thanks a lot @aureliogrb. |
3 participants
As requested bringing the pool to the 25.0.0 branch