Add library-and-framework-list.json to the packaging of future graalvm-reachability-metadata releases #698
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vjovanov
approved these changes
Nov 4, 2025
melix
approved these changes
Nov 4, 2025
I added it just to be safe, so if someone decided to tinker with the repository and moved or removed the file, it wouldn't break the packaging. If you think this is not the way to go (and we SHOULD crash if someone decides to move/remove the file), I can remove the |
|
I would remove the if. Nothing is worse than silent errors :) |
…m-reachability-metadata releases
jormundur00
force-pushed
the
jvukicev/package-library-and-framework-list
branch
from
d5d8c98 to
77e4186
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
In this PR we add packaging of
library-and-framework-list.jsonto all futuregraalvm-reachability-metadatareleases. The data provided in this file can be used by Native Build Tools to improve the accuracy of the native image dynamic access analysis, and should hence be packaged with the future releases.