[GR-42465] Reset JDKs cgroup metrics instances #5400
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
zakkak
suggested changes
Nov 10, 2022
substratevm/src/com.oracle.svm.core/src/com/oracle/svm/core/Containers.java
Outdated
Show resolved
Hide resolved
jerboaa
changed the title
zakkak
approved these changes
Nov 10, 2022
jerboaa
force-pushed
the
containers_native_jfr_fix_2
branch
from
c811085 to
d0a9565
Compare
fniephaus
changed the title
|
Thank you! |
fniephaus
reviewed
Nov 16, 2022
substratevm/src/com.oracle.svm.core/src/com/oracle/svm/core/jdk/JDKContainerSubstitutions.java
Outdated
Show resolved
Hide resolved
fniephaus
reviewed
Nov 18, 2022
substratevm/src/com.oracle.svm.core/src/com/oracle/svm/core/jdk/JDKContainerSubstitutions.java
Show resolved
Hide resolved
This is needed in order to get correct memory limits detected for some code paths (one of which is JFR). Reset containerMetrics and initializationTriggered static variables in JDKEvents class so as to not carry over build-time information to runtime. Similarly, reset RequestEngine.entries list to an empty list so that initialization doesn't re-add hooks added at build time. Closes: oracle#5396
jerboaa
force-pushed
the
containers_native_jfr_fix_2
branch
from
d0a9565 to
a7ea29b
Compare
|
@fniephaus It's my understanding that |
Yup they seem to be working now. I'll update the task list. Thank you! |
|
@fniephaus Are there any other issues with this patch that aren't addressed, yet? Thanks! |
|
Thanks for resolving the open issue and for the delay. I've asked for another internal review and will merge this when all is well. |
|
Thanks for the heads-up! |
|
The PR is now in our merge queue. |
|
Thanks! |
|
This was merged via a01e8b7. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed in order to get correct memory limits detected for some code paths (one of which is JFR).
Closes: #5396