[GR-33549] Run image-builder on modulepath when module options are used. #3763
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ilder from driver
…t-library --macro:native-image-agent-library --macro:native-image-configure-launcher work again
….nativeimage.objectfile
…uite_constituents
ivan-ristovic
approved these changes
Sep 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ivan-ristovic please have a look. This will eliminate the need for using
USE_NATIVE_IMAGE_JAVA_PLATFORM_MODULE_SYSTEM=true.Whenever native-images gets passed
-por-m(or the equivalent long forms) the driver will switch to running the image builder on modulepath. Note thatUSE_NATIVE_IMAGE_JAVA_PLATFORM_MODULE_SYSTEM=truecan still be used to force running the image builder on modulepath even when no-por-mis used.