Fix checkstyle issues in generated code #193
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
“static final” is the recommended order by JLS. Signed-off-by: Stefan Marr <git@stefan-marr.de>
|
Warning: some required labels were not added by the current assignee @grimmerm. In a normal review process, the assignee is responsible for adding labels to the pull request. Contentious labels: |
|
Thanks |
dougxc
pushed a commit
that referenced
this pull request
Sep 8, 2016
…/truffle:dsl_fix_implicit_evaluated_parameters to master * commit 'cdecd17ca1533cd9ea55f89befd348624e6c184e': Add test for implicit casts for type in evaluated execute methods. Fix use new fallthrough flag also for slow path generation. Fix execute methods with typed evaluated parameters that are implicitely casted with a subtype as source type should do the implicit type guard to inject specialized information.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the generated code to use “static final” as it is the recommended order by JLS.
Also fix two minor whitespace issues.