[GR-42804] Disallow System.err and printStackTrace().#12854
Closed
graalvmbot wants to merge 7 commits into
Closed
Conversation
oracle-contributor-agreement
Bot
added
the
OCA Verified
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds two new checkstyle rules: one that disallows the use of
System.errand one to disallowThrowable.printStackTrace()in the SVM code base.The Native Image builder itself should always print into stdout to ensure that warnings and errors are captured together with the build output. In general, the use of
System.errshould be explicitly signed off with a comment when required.Similarly, we use
printStackTrace(PrintStream s)overprintStackTrace()to ensure that the output stream is explicitly chosen. This PR also fixes some places where we printed something to stdout, and then calledprintStackTrace()which prints to stderr.