[GR-71140] Adopt caching added to Annotated.getDeclaredAnnotationInfo #12489
+472
−242
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adopts the support added for caching parsed annotations and leverages it to remove caches in
AnnotatedObjectAccessandAnnotatedValueSupport.As hinted by its name,
jdk.vm.ci.meta.annotation.AbstractAnnotated#getDeclaredAnnotationInfoonly pertains to declared annotations (i.e. ignores inherited annotations). All other annotation caches have been removed as they had no real benefit. This was ascertained by running the following insubstratevm-enterprise:with some extra printfs added to show cache hits and misses:
As expected, the only caches that really mattered were
AnnotatedObjectAccess.declaredAnnotationCacheandAnnotatedObjectAccess.resolvedAnnotationsCachewhich are now replaced by the caches injdk.vm.ci.meta.annotation.AbstractAnnotatedandjdk.graal.compiler.annotation.AnnotationValue#annotationCacherespectively.