[GR-69102] Use AbstractImageHeapList to restrict SubstrateDiagnostics.thunks runtime type. #12132
      
        
          +54
        
        
          −17
        
        
          
        
      
    
  
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Introduce
AbstractImageHeapListas a super type forHostedImageHeapListandRuntimeImageHeapList. This allows declaring a more restricted type for fields initialized withImageHeapList#create(Class)to aid open-world analysis. When such a field is analysed in an open-world it gets injected all possible subtypes of its declared type. Declaring the type asAbstractImageHeapListallows us to only injectRuntimeImageHeapList.This enables a more precise analysis and avoids for example triggering false-positive violations of@RestrictHeapAccess: if the field was declared asListthen implementations ofListfor which simple access operations can allocate, such asArrayList#get(int), could become reachable from code annotated with@RestrictHeapAccess.