Skip to content

Conversation

Eng-Fouad
Copy link

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Jun 17, 2025
@oubidar-Abderrahim
Copy link
Member

Thank you for contributing to GraalVM
@wirthi could you please assign someone to evaluate the changes and review it? Thank you

@oubidar-Abderrahim oubidar-Abderrahim self-assigned this Aug 29, 2025
@wirthi wirthi requested a review from zapster September 2, 2025 16:02
@zapster
Copy link
Member

zapster commented Sep 5, 2025

Thanks for your contribution @Eng-Fouad. Initialing HijrahChronology at build time, which you basically did with reverting 9ebb22d, is the right direction in this case. However, it reintroduces the problem the commit tried to solve, i.e., the problem of storing the build-time JAVA_HOME path value in the CONF field. This is problematic because the path is will be used at run time for extra chronology configuration resolution, but the path might no longer be valid. The image might not even run on the same machine. I have a fix for that, but it needs a bit more polishing. I'll open a PR next week and be sure that it is linked here. Stay tuned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Native Image] HijrahChronology is broken in native mode
4 participants