[GR-65294] Fix Class.forName folding when respecting class loaders.
#11301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At build-time `ClassLoader.getSystemClassLoader()` is the native image class loader. It is replaced by an application class loader for use at runtime. In reflection plugins we observe what will become the runtime value, not the native image class loader.
We should never resolve package-less classes in the modules file.
oracle-contributor-agreement
bot
added
the
OCA Verified
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
Class.forNamefolding when respecting class loadersAt build-time
ClassLoader.getSystemClassLoader()is the native image class loader.It is replaced by an application class loader for use at runtime.
In reflection plugins we observe what will become the runtime value, not the native image class loader.
Fix NPE when looking up package-less classes in the boot registry.
We should never resolve package-less classes in the modules file.