Skip to content

[GR-64824] Only compute heap dumping metadata if needed. #11153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 10, 2025
Merged

[GR-64824] Only compute heap dumping metadata if needed. #11153

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 16 additions & 4 deletions substratevm/src/com.oracle.svm.hosted/src/com/oracle/svm/hosted/heap/HeapDumpFeature.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
*/
package com.oracle.svm.hosted.heap;

import java.lang.reflect.Field;
import java.nio.charset.StandardCharsets;
import java.util.ArrayList;
import java.util.Collection;
Expand Down Expand Up @@ -51,6 +52,7 @@
import com.oracle.svm.core.util.ByteArrayReader;
import com.oracle.svm.core.util.VMError;
import com.oracle.svm.hosted.FeatureImpl.AfterCompilationAccessImpl;
import com.oracle.svm.util.ReflectionUtil;

import jdk.graal.compiler.core.common.util.TypeConversion;
import jdk.graal.compiler.core.common.util.UnsafeArrayTypeWriter;
Expand All @@ -65,6 +67,8 @@
*/
@AutomaticallyRegisteredFeature
public class HeapDumpFeature implements InternalFeature {
private boolean isDataFieldReachable;

@Override
public boolean isInConfiguration(IsInConfigurationAccess access) {
/*
Expand Down Expand Up @@ -95,12 +99,20 @@ public void beforeAnalysis(BeforeAnalysisAccess access) {
}
}

@Override
public void afterAnalysis(AfterAnalysisAccess access) {
Field dataField = ReflectionUtil.lookupField(HeapDumpMetadata.class, "data");
isDataFieldReachable = access.isReachable(dataField);
}

@Override
public void afterCompilation(Feature.AfterCompilationAccess access) {
AfterCompilationAccessImpl accessImpl = (AfterCompilationAccessImpl) access;
byte[] metadata = encodeMetadata(accessImpl.getTypes());
HeapDumpMetadata.singleton().setData(metadata);
access.registerAsImmutable(metadata);
if (isDataFieldReachable) {
AfterCompilationAccessImpl accessImpl = (AfterCompilationAccessImpl) access;
byte[] metadata = encodeMetadata(accessImpl.getTypes());
HeapDumpMetadata.singleton().setData(metadata);
access.registerAsImmutable(metadata);
}
}

/**
Expand Down