[GR-44352] [GR-61906] Mark ZoneOffset.rules with RecomputeFieldValue #10663
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
java.time.ZoneOffset
is initialized at build time as a side effect of initializingsun.security.ssl.SSLContextImpl$AbstractTLSContext
. During this initialization,ZoneOffset.getRules()
method gets called on the constantZoneOffset.UTC
and therefore theZoneOffset.UTC.rules
field gets initialized to anon-null
value. As this field is marked as@Stable
, simulated class initialization may constant fold any associatedLoadFieldNode
. Therefore, the success of the simulation ofZoneOffset.UTC.getRules()
depends on whether thegetRules()
method was already called at buildtime onZOneOffset.UTC
and as there is no synchronization between those events, the result of the simulation is non-deterministic.To achieve deterministic analysis results, we mark the field with
RecomputeFieldValue
to prevent its constant folding.