[GR-61494] [GR-60855] Analysis Refactoring & Minor Improvements #10660
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the analysis code to reduce ambiguity and introduce more invariants. In particular, the following changes are made:
AnalysisMethod.isEntryPoint()
was renamed toAnalysisMethod.isNativeEntryPoint()
to minimize the chances that it would be incorrectly used to collect call graph root methods, which are in some context also called entrypoints, but not all root methods are (native) entry points. The call graph obtained by starting from native entrypoints would not include all reachable methods.This PR also fixes three issues of the CSV call graph. In this context, the word entrypoint means root (hence the confusion).
The following invariant now holds for all CSV call graphs that Native Image generates:
call_tree_methods_*.csv
are reachable. In particular, each method is either an entrypoint, reachable from an entrypoint, or a call target of an invoke.