jlink fails with java.io.IOException: Invalid JMOD file

[metametadata]

jlink doesn't work in 20.3.0. But seems to work in the latest dev build.

Steps to reproduce the issue
Invoke jlink. Observe the output.

Expected

Error: --output must be specified
Usage: jlink --module-path --add-modules [,...]
Use --help for a list of possible options

Actual

Error: java.io.IOException: Invalid JMOD file: /Users/yuri/.sdkman/candidates/java/20.3.0.r11-grl/jmods/jdk.jartool.jmod

Describe GraalVM and your environment:

• GraalVM version: 20.3.0

  openjdk version "11.0.9" 2020-10-20
  OpenJDK Runtime Environment GraalVM CE 20.3.0 (build 11.0.9+10-jvmci-20.3-b06)
  OpenJDK 64-Bit Server VM GraalVM CE 20.3.0 (build 11.0.9+10-jvmci-20.3-b06, mixed mode, sharing)

• JDK major version: 11.
• OS: macOS Catalina 10.15.6.
• Architecture: AMD64.

More details

• On macOS JDKs were installed using sdkman.
• Also reproducible in Windows 2012 (installing via choco install -y graalvm --version 20.3.0).
• Doesn't seem to be reproducible in v20.0.0 and v20.2.0.
• Doesn't seem to be reproducible in graalvm-ce-java11-21.1.0-dev.

[oubidar-Abderrahim]

If it cannot be reproduced in the latest dev, that means that the bug was already fixed.
Since there's no action for us to do here, I am closing the issue.

[tjwatson]

This is reproducible on 21.0.0 also.

[tjwatson]

I did test GraalVM CE 21.1.0-dev-20210120_0306 and it does work with that. Not sure if the final release process is somehow corrupting this module. Hopefully the 21.1.0 release will prove otherwise and it works in the release of 21.1.0.

[oubidar-Abderrahim]

I tested on my macOS. it seems that the only part that is not working is invoking jlink without any parameters (which is supposed to throw Error: --output must be specified message). but running commands like jlink --help jlink --version jlink --list-plugins seems to be running without issues.

Please verify that this is the case for you too.

[tjwatson]

I can verify that graalvm-ce-java11-21.0.0 correctly prints messages when using --help, --version, --list-plugins. But fails with Invalid JMOD file: .../graalvm-ce-java11-21.0.0/Contents/Home/jmods/jdk.jartool.jmod when invoked with no parameters.

Other interesting thing:

graalvm-ce-java11-21.0.0/Contents/Home/bin/jlink --version
11.0.10

vs.

graalvm-ce-java11-21.1.0-dev/Contents/Home/bin/jlink --version
11.0.9

I was not expecting the version to go down 11.0.10 -> 11.0.9

Perhaps the release is pulling in a mismatched version?

[metametadata]

Please verify that this is the case for you too.

It's the case for me with 20.3.0 and 21.0.0 on macOS. But just in case, my main issue is that building of a new JVM fails with the error. Example:

~ ᐅ jlink --add-modules java.naming --output foo
Error: java.io.IOException: Invalid JMOD file: /Users/yuri/.sdkman/candidates/java/21.0.0.r11-grl/jmods/jdk.jartool.jmod

[oubidar-Abderrahim]

Issue tracked internally on GR-28952

[xodbc]

on windows:
21.0.0 ×
20.3.1 ×
20.3.0 ×
jlink --module-path jmods --add-modules java.base --output jre Error: java.io.IOException: Invalid JMOD file: xxx\java.base.jmod
20.2.0 √

and v20.2.0 jre:
ClassNotFoundException: org.graalvm.compiler.hotspot.management.JMXToLibGraalCalls

[gilles-duboscq]

Yes, the same bug affects both windows and darwin. Should be fixed for future releases.

[tjwatson]

For the latest release 21.0.0.2 on the Mac it seems jlink now launches and tries to do something but now I get errors like this when trying to create the jlink image:

[ERROR] Error: Hash of java.management (ebf0ea14412a93994827c313e130b5dce32cfa61e2ce7eafe629842c1e74f1b8) differs to expected hash (6c502b1f9b010ac21e35dca42053ca6ac5b08d2f3468f72545c981e72a843880) recorded in java.base

To reproduce clone https://github.com/apache/felix-atomos.git and run mvn clean install -Pequinox from the felix-atomos directory.

There is a jlink example atomos.examples.jlink that will fail to create the jlink image (using moditect plugin)

java -version
openjdk version "11.0.10" 2021-01-19
OpenJDK Runtime Environment GraalVM CE 21.0.0.2 (build 11.0.10+8-jvmci-21.0-b06)
OpenJDK 64-Bit Server VM GraalVM CE 21.0.0.2 (build 11.0.10+8-jvmci-21.0-b06, mixed mode, sharing)