enhance the existing Tuxedo dockerfiles #455

DongHan2016 · 2017-07-07T11:31:17Z

No description provided.

DongHan2016 · 2017-07-07T11:33:35Z

The following files and folders under OracleTuxedo would be removed after merged.

COPYRIGHT
LICENSE
dockerfiles
samples

brunoborges · 2017-07-08T01:05:35Z

This PR is actually about the core folder, then?

Djelibeybi

Please review the CONTRIBUTING.md file in the root of the GitHub repo as there are still some Golden Rules being broken. The biggest one that appears to affect all the Dockerfiles is a lack of CMD or ENTRYPOINT directive in any of them.

Djelibeybi · 2017-07-08T05:07:47Z

OracleTuxedo/core/samples/mp/Dockerfile

+# 
+
+# Pull base image
+FROM oracle/tuxedo:<VERSION>


This is an invalid FROM line. You'll need to make it specific.

Djelibeybi · 2017-07-08T05:08:50Z

OracleTuxedo/core/dockerfiles/12.1.3/Dockerfile

+#RUN yum -y install bind-utils
+
+USER oracle
+WORKDIR /u01/oracle


There is no CMD or ENTRYPOINT command, which is against the Golden Rules as stated in the contribution guide. Please provide one, even if all it outputs is documentation on how to find more information on extending this image.

The dockerfile is to show how to build a Tuxedo docker image. Then users coudl develop or deploy their apps on the image. Will output how to use the docker image.

Djelibeybi · 2017-07-08T05:09:01Z

OracleTuxedo/core/dockerfiles/12.2.2/Dockerfile

+#RUN yum -y install bind-utils
+
+USER oracle
+WORKDIR /u01/oracle


There is no CMD or ENTRYPOINT command, which is against the Golden Rules as stated in the contribution guide. Please provide one, even if all it outputs is documentation on how to find more information on extending this image.

The dockerfile is to show how to build a Tuxedo docker image. Then users coudl develop or deploy their apps on the image. Will output how to use the docker image.

Djelibeybi · 2017-07-08T05:11:21Z

OracleTuxedo/core/dockerfiles/fix_locations.sh

@@ -0,0 +1,32 @@
+#!/bin/sh
+#
+# This script modifies the installer scripts and response files to match the local environment.


Instead of changing paths using an external script, can't you do this the standard Docker way using either --build-arg for build time changes or -e for runtime changes? That would be much better in terms of 3rd-party orchestration support.

The file will be removed.

Djelibeybi · 2017-07-08T05:12:36Z

OracleTuxedo/core/dockerfiles/buildDockerImage.sh

+  exit 
+fi
+
+# You may need uncomment the following lines and RP file name if you need check the RP md5sum value:


There is a lot of commented out code here. If you don't need it, remove it. If you need it, uncomment it and make sure it works.

Djelibeybi · 2017-07-08T05:17:00Z

OracleTuxedo/core/samples/mp/Dockerfile

+
+WORKDIR /u01/oracle/simpappmp
+
+RUN sh -x ../simpappmp_runme.sh


There is no CMD or ENTRYPOINT in this sample, so it's not going to do anything at runtime.

The dockerfile is for the mp sample. we will output how to run the sample through CMD/ENTRYPOINT.

Djelibeybi · 2017-07-08T05:18:30Z

OracleTuxedo/core/samples/shm/Dockerfile

+WORKDIR /u01/oracle
+
+# Define ENTRYPOINT. 
+ENTRYPOINT ["bash","/u01/oracle/simpapp_runme.sh"]


Please don't run bash directly. Just make sure your script is executable and has the bash shebang line at the top.

Djelibeybi · 2017-07-08T05:19:23Z

OracleTuxedo/core/samples/shm/build.sh

+docker build -t oracle/tuxedoshm .
+
+echo "To run the sample, use:"
+echo "docker run -ti -v \${Local_volumes_dir}/TuxedoVolumes/\${VERSION}:/u01/oracle/user_projects oracle/tuxedoshm /bin/bash"


Don't suggest -ti and running /bin/bash. It should be run with -d in the background and a CMD or ENTRYPOINT script should handle whatever process needs to be run.

Djelibeybi · 2017-07-08T05:19:47Z

OracleTuxedo/core/samples/shm/simpapp_runme.sh

@@ -0,0 +1,95 @@
+#!/bin/sh


If you intend this script to be run by bash, you need to change this to #!/bin/bash.

Djelibeybi · 2017-07-08T05:20:16Z

OracleTuxedo/core/samples/shm/simpapp_runme.sh

+    then
+  if [ "$1" = "12.1.3" ]
+  then
+	export TUXDIR=~/tuxHome/tuxedo12.1.3.0.0


Isn't $TUXDIR set in the parent image? You shouldn't need to work out what it is downstream.

DongHan2016 · 2017-07-09T16:37:42Z

@brunoborges, yes, it's for core folder. After the PR is merged, the original folder should be removed.

brunoborges

Approved pending changes requested by @Djelibeybi

brunoborges

Waiting for requested changes submitted by @Djelibeybi to be applied

removed the useless file

Updated following files: core/dockerfiles/12.1.3/Dockerfile core/dockerfiles/12.2.2/Dockerfile core/dockerfiles/buildDockerImage.sh core/dockerfiles/README.md core/README.md core/samples/mp/docker-compose.yml core/samples/mp/Dockerfile core/samples/mp/simpappmp_runme.sh core/samples/shm/build.sh core/samples/shm/Dockerfile core/samples/shm/simpapp_runme.sh Additions: core/dockerfiles/12.1.3: init.sh core/dockerfiles/12.2.2: init.sh core/samples/mp: simpappmp_build.sh Removals: core/dockerfiles/12.1.3: tuxedo12.1.3.rsp.template core/dockerfiles/12.1.3: tuxedo12.1.3_silent_install.sh.template core/dockerfiles: fix_locations.sh core/dockerfiles: tuxedo.docker

Djelibeybi

This latest commit has improved things, but you're still considering the containers as if they were VMs, which they're not.

You should always keep in mind that users must never be required to login into or attach to a running container. They need to be self-contained and all access is done remotely.

So, for your samples, you may need to expose some ports and explain how to test/validate the application externally.

Djelibeybi · 2017-07-11T03:46:18Z

OracleTuxedo/core/dockerfiles/12.1.3/Dockerfile

    mkdir -p /u01 && chmod a+xr /u01 && \
    groupadd -g 1000 oracle && useradd -b /u01 -m -g oracle -u 1000 -s /bin/bash oracle 

 # Copy packages
 # -------------
 COPY tuxedo12.1.3.rsp $TUX_PKG /u01/
+COPY init.sh /u01/oracle/
 COPY oraInst.loc /etc/


You should combine these three COPY directives into one.

Djelibeybi · 2017-07-11T03:46:38Z

OracleTuxedo/core/dockerfiles/12.1.3/Dockerfile

 COPY oraInst.loc /etc/
 RUN  chown oracle:oracle -R /u01
+RUN  chmod +x /u01/oracle/init.sh


You should combine these two RUN directives into one.

Djelibeybi · 2017-07-11T03:47:15Z

OracleTuxedo/core/dockerfiles/12.1.3/init.sh

+echo ""
+echo "This image is designed as base image of Tuxedo applications, user needs to deploy applications, source codes, configuration files, and other necessary settings to the container, build source codes, boot the tuxedo domains, run the applications, and shutdown tuxedo domains. There are 2 samples: shm and mp for your reference."
+
+tail -f /dev/null


Remove this tail. If the entire point of the image is to be used as a base for other images, you don't want it to keep running. You want it to exist automatically.

Djelibeybi · 2017-07-11T04:02:38Z

OracleTuxedo/core/dockerfiles/12.1.3/init.sh

@@ -0,0 +1,6 @@
+#!/bin/bash


Please rewrite the following two echo lines to:

This sample Docker image is provided by Oracle and is designed to be used as a base image from which you can build Tuxedo-based applications.

To help you get started customizing this image, we've provided two sample applications ("shm" and "mp") in the Oracle Docker Images GitHub repository. These samples demonstrate how to deploy applications, source code, configuration files and the other necessary settings to build Tuxedo-enabled application containers.

For more information on this image, please visit the Oracle Docker Images GitHub repository at https://github.com/oracle/docker-images.

For more information on Tuxedo, please read the Oracle Tuxedo documentation at http://docs.oracle.com/cd/E53645_01/tuxedo/docs12cr2/index.html.

Djelibeybi · 2017-07-11T04:04:06Z

OracleTuxedo/core/dockerfiles/12.2.2/Dockerfile

    mkdir -p /u01 && chmod a+xr /u01 && \
    groupadd -g 1000 oracle && useradd -b /u01 -m -g oracle -u 1000 -s /bin/bash oracle 

 # Copy packages
 # -------------
 COPY tuxedo12.2.2.rsp $TUX_PKG /u01/
+COPY init.sh /u01/oracle/
 COPY oraInst.loc /etc/


Please combine these three COPY directives into one.

Djelibeybi · 2017-07-11T04:10:26Z

OracleTuxedo/core/dockerfiles/buildDockerImage.sh

 if [ "$?" = "0" ]
    then
 	echo ""
 	echo "Tuxedo Docker image is ready to be used. To create a container, run:"
-	echo "docker run -ti -v \${LOCAL_DIR}:/u01/oracle/user_projects oracle/tuxedo:${VERSION} /bin/bash"
+	echo "docker run -d -v \${LOCAL_DIR}:/u01/oracle/user_projects oracle/tuxedo:${VERSION} /bin/bash"


Please do not ask users to run /bin/bash. This is a container, not a VM. The CMD or ENTRYPOINT script should run and that should provide the required functionality.

Djelibeybi · 2017-07-11T04:11:54Z

OracleTuxedo/core/samples/mp/Dockerfile

-MAINTAINER Judy Liu<judy.liu@oracle.com>
-COPY simpapp_runme.sh simpappmp_runme.sh sleep.sh start_tlisten.sh /u01/oracle/
+MAINTAINER Todd Little<todd.little@oracle.com>
+COPY simpappmp_build.sh simpappmp_runme.sh sleep.sh start_tlisten.sh /u01/oracle/


You should switch to the oracle user first (i.e. USER oracle) and then do the COPY so that you don't need to chown anything. You should be able to remove those lines completely.

Djelibeybi · 2017-07-11T04:12:19Z

OracleTuxedo/core/samples/mp/Dockerfile

+RUN sh -x ../simpappmp_build.sh
+
+# Define ENTRYPOINT. 
+ENTRYPOINT ["/u01/oracle/init.sh"]


This will just run the upstream init.sh instead of running your sample. You need to create a script that actually runs your sample application, so it's useful.

Like the shm sample, you probably want to run simpappmp_runme.sh here.

Djelibeybi · 2017-07-11T04:16:04Z

OracleTuxedo/core/samples/shm/build.sh

@@ -2,4 +2,5 @@
 docker build -t oracle/tuxedoshm .

 echo "To run the sample, use:"
-echo "docker run -ti -v \${Local_volumes_dir}/TuxedoVolumes/\${VERSION}:/u01/oracle/user_projects oracle/tuxedoshm /bin/bash"
+echo "docker run -d --name tuxedoshm -v \${Local_volumes_dir}/TuxedoVolumes/\${VERSION}:/u01/oracle/user_projects oracle/tuxedoshm /bin/bash"


Do not ask the user to run /bin/bash. Your image should automatically run the appropriate script or process via CMD or ENTRYPOINT.

Djelibeybi · 2017-07-11T04:16:42Z

OracleTuxedo/core/samples/shm/build.sh

@@ -2,4 +2,5 @@
 docker build -t oracle/tuxedoshm .

 echo "To run the sample, use:"
-echo "docker run -ti -v \${Local_volumes_dir}/TuxedoVolumes/\${VERSION}:/u01/oracle/user_projects oracle/tuxedoshm /bin/bash"
+echo "docker run -d --name tuxedoshm -v \${Local_volumes_dir}/TuxedoVolumes/\${VERSION}:/u01/oracle/user_projects oracle/tuxedoshm /bin/bash"
+echo "docker start tuxedoshm; docker attach tuxedoshm"


The docker run command will automatically start the container. And you shouldn't need to attach to a running container at all. This line should be removed.

Rather, you probably should provide instructions on how to test/validate the application is working from outside the containers.

1. removed core/samples to tuxedo_full as the samples are dependent on TSAM which is not installed in the docker 2. removed dockerfiles and samples folders under the original Tuxedo folder (OracleTuxedo) 3. updated the files according to the new comments in PR455.

DongHan2016 added 2 commits July 7, 2017 19:25

Add files via upload

1191f9f

Update README.md

98abe99

brunoborges requested review from Djelibeybi, brunoborges and mriccell and removed request for mriccell July 8, 2017 01:05

Djelibeybi suggested changes Jul 8, 2017

View reviewed changes

brunoborges approved these changes Jul 10, 2017

View reviewed changes

brunoborges suggested changes Jul 10, 2017

View reviewed changes

DongHan2016 added 3 commits July 10, 2017 18:17

Delete tuxedo12.1.3.rsp.template

142282d

removed the useless file

Delete tuxedo12.1.3_silent_install.sh.template

6a69b07

removed the useless file

Djelibeybi suggested changes Jul 11, 2017

View reviewed changes

Djelibeybi approved these changes Jul 13, 2017

View reviewed changes

brunoborges approved these changes Jul 14, 2017

View reviewed changes

Djelibeybi merged commit 12e8cdd into oracle:master Jul 14, 2017


		WORKDIR /u01/oracle/simpappmp

		RUN sh -x ../simpappmp_runme.sh

enhance the existing Tuxedo dockerfiles #455

enhance the existing Tuxedo dockerfiles #455

Uh oh!

Conversation

DongHan2016 commented Jul 7, 2017

Uh oh!

DongHan2016 commented Jul 7, 2017

Uh oh!

brunoborges commented Jul 8, 2017

Uh oh!

Djelibeybi left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

DongHan2016 commented Jul 9, 2017

Uh oh!

brunoborges left a comment

Choose a reason for hiding this comment

Uh oh!

brunoborges left a comment

Choose a reason for hiding this comment

Uh oh!

Djelibeybi left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!