Adding glassfish nightly and nightly-web docker files #398
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….1 and 4.1.1-web image" Changed the jdk to 1.7 for 4.1.1 and 4.1.1 web
Djelibeybi
suggested changes
May 26, 2017
GlassFish/nightly-web/Dockerfile
Outdated
| # Setup password file | ||
| # Enable DAS | ||
| RUN yum -y install wget unzip java-1.8.0-openjdk-devel && \ | ||
| wget --quiet --no-check-certificate $GLASSFISH_URL && \ |
There was a problem hiding this comment.
Please remove the --no-check-certificate parameter to wget. It is not acceptable to bypass SSL/TLS certificate validation when downloading binaries.
GlassFish/nightly/Dockerfile
Outdated
| # Setup password file | ||
| # Enable DAS | ||
| RUN yum -y install wget unzip java-1.8.0-openjdk-devel && \ | ||
| wget --quiet --no-check-certificate $GLASSFISH_URL && \ |
There was a problem hiding this comment.
Please remove the --no-check-certificate parameter to wget. It is not acceptable to bypass SSL/TLS certificate validation when downloading binaries.
GlassFish/nightly-web/Dockerfile
Outdated
| # Install packages, download and extract GlassFish | ||
| # Setup password file | ||
| # Enable DAS | ||
| RUN yum -y install wget unzip java-1.8.0-openjdk-devel && \ |
There was a problem hiding this comment.
You should remove the requirement for wget and just use curl instead which is already in the 7-slim image.
GlassFish/nightly/Dockerfile
Outdated
| # Install packages, download and extract GlassFish | ||
| # Setup password file | ||
| # Enable DAS | ||
| RUN yum -y install wget unzip java-1.8.0-openjdk-devel && \ |
There was a problem hiding this comment.
You should remove the requirement for wget and just use curl instead which is already in the 7-slim image.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.