rolling-router-sticky-sessions ui added #395
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karthequian
reviewed
May 22, 2017
| cd /tmp && \ | ||
| mkdir unzip && \ | ||
| wget https://bitbucket.org/nginx-goodies/nginx-sticky-module-ng/get/08a395c66e42.zip && \ | ||
| unzip 08a395c66e42.zip -d unzip && \ | ||
| ls -la /tmp/unzip && \ |
There was a problem hiding this comment.
@mikarinneoracle why do we need this?
There was a problem hiding this comment.
We don't. I will remove.
|
@karthequian Should I fix the code indentation? I realized my Atom is using tabs, should I change to spaces (4) instead ? |
|
@mikarinneoracle I did not see that initially, but I agree. 4 spaces would work better, especially in the php/js code you have. It might make reading it easier, and more consistent with the rest of the files. Thanks for the PR! |
|
@karthequian Ok, indentation fixed for readability. Thanks! |
|
@karthequian @mikeraab Hi, I updated the README and did a small fix to error handling in case of network connect error. Please review. |
|
looks good to me @mikeraab |
|
Thanks Guys, merging now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.