-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow the initial amount of memory for databases to be configurable #1576
Allow the initial amount of memory for databases to be configurable #1576
Conversation
Signed-off-by: Steve Swinsburg <steve.swinsburg@gmail.com>
…eswinsburg/docker-images into feature/configurable-memory * 'feature/configurable-memory' of https://github.com/steveswinsburg/docker-images: Make memory configurable in 19c
Signed-off-by: Steve Swinsburg <steve.swinsburg@gmail.com>
@gvenzl OCA verified. Please go ahead and review. |
@yunus-qureshi @latakannan @rishabh20oracle, can you please take a look at this PR please and evaluate the ability to pass on memory requirements to the database? Ideally, this parameter takes effect also when a database is started, not only when it's created. The question is whether we can easily retrieve the configured parameter without having to startup the database, retrieve the memory, and then restart the DB with the new value if it has changed. Also, please have a look at https://stackoverflow.com/questions/42187085/check-mem-limit-within-a-docker-container. We need to also verify whether the container does even have enough memory that is requested by the parameter. |
@gvenzl @yunus-qureshi @latakannan I see a few concerns with this PR and I have few use-cases in mind where this will not address the problems that we intend to solve with this enhancement.
|
Closing this PR as the recommended way for giving control to the user to set memory limits is to allow them to set SGA and PGA size. Opened another PR #1742 which implements that functionality. |
This is the PR for #1575.
I have only added this for Oracle 19c. Let me know if this needs to be added for the other versions as well.
Also note I submitted the OCA on 13th April 2020.