Skip to content

Minor updates to cache-storage commands #331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 30, 2025
Merged

Minor updates to cache-storage commands #331

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions pkg/cmd/formatting.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1027,8 +1027,8 @@ func FormatCacheDetailsStorage(cacheDetails []config.CacheDetail) string {
"FILTER LISTENERS", "MAX QUERY MS", "MAX QUERY DESC").MaxLength(maxLength).WithSortingColumn(NodeIDColumn)

if OutputFormat == constants.WIDE {
table.AddHeaderColumns("NO OPT AVG", "OPT AVG", "INDEX SIZE", "INDEXING MILLIS")
table.WithAlignment(R, L, R, R, R, R, R, L, R, R, R, R)
table.AddHeaderColumns("NO OPT AVG", CountColumn, "OPT AVG", CountColumn, "INDEX SIZE", "INDEXING MILLIS")
table.WithAlignment(R, L, R, R, R, R, R, L, R, R, R, R, R, R)
} else {
table.WithAlignment(R, L, R, R, R, R, R, L)
}
Expand All @@ -1045,8 +1045,9 @@ func FormatCacheDetailsStorage(cacheDetails []config.CacheDetail) string {
formatLargeInteger(value.MaxQueryDurationMillis), value.MaxQueryDescription)
if OutputFormat == constants.WIDE {
table.AddColumnsToRow(formatFloat(float32(value.NonOptimizedQueryAverageMillis)),
formatFloat(float32(value.OptimizedQueryAverageMillis)),
formattingFunction(value.IndexTotalUnits), formatLargeInteger(value.IndexingTotalMillis))
formatLargeInteger(value.NonOptimizedQueryCount), formatFloat(float32(value.OptimizedQueryAverageMillis)),
formatLargeInteger(value.OptimizedQueryCount), formattingFunction(value.IndexTotalUnits),
formatLargeInteger(value.IndexingTotalMillis))
}
}

Expand Down
2 changes: 2 additions & 0 deletions pkg/config/config_helper.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -620,7 +620,9 @@ type CacheDetail struct {
MaxQueryDurationMillis int64 `json:"maxQueryDurationMillis"`
MaxQueryDescription string `json:"maxQueryDescription"`
NonOptimizedQueryAverageMillis float64 `json:"nonOptimizedQueryAverageMillis"`
NonOptimizedQueryCount int64 `json:"nonOptimizedQueryCount"`
OptimizedQueryAverageMillis float64 `json:"optimizedQueryAverageMillis"`
OptimizedQueryCount int64 `json:"optimizedQueryCount"`
IndexTotalUnits int64 `json:"indexTotalUnits"`
IndexingTotalMillis int64 `json:"indexingTotalMillis"`
IndexInfo []string `json:"indexInfo"`
Expand Down
Loading