Skip to content

Do not log the password #254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 18, 2025
Merged

Do not log the password #254

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
375e63b
Do not log the password; fix whitespace
Sep 3, 2025
e09bd99
Merge branch 'main' into logfix
gotsysdba Sep 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions src/client/mcp/rag/optimizer_utils/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ def get_llm(data):
logger.info(llm_config)
provider = llm_config["provider"]
url = llm_config["api_base"]
api_key = llm_config["api_key"]
api_key = llm_config["api_key"]

logger.info(f"CHAT_MODEL: {model} {provider} {url} {api_key}")
if provider == "ollama":
Expand Down Expand Up @@ -82,7 +82,7 @@ def get_vectorstore(data, embeddings):

db_by_name = {m["name"]: m for m in data.get("database_configs", [])}
db_config= db_by_name.get(db_alias)

table_alias=data["client_settings"]["vector_search"]["alias"]
model=data["client_settings"]["vector_search"]["model"]
chunk_size=str(data["client_settings"]["vector_search"]["chunk_size"])
Expand All @@ -97,8 +97,8 @@ def get_vectorstore(data, embeddings):
user=db_config["user"]
password=db_config["password"]
dsn=db_config["dsn"]
logger.info(f"{db_table}: {user}/{password} - {dsn}")

logger.info(f"{db_table}: {user} - {dsn}")
conn23c = oracledb.connect(user=user, password=password, dsn=dsn)

logger.info("DB Connection successful!")
Expand All @@ -109,8 +109,8 @@ def get_vectorstore(data, embeddings):
dist_strategy = DistanceStrategy.COSINE
elif metric == "EUCLIDEAN":
dist_strategy = DistanceStrategy.EUCLIDEAN

logger.info(embeddings)
knowledge_base = OracleVS(client=conn23c,table_name=db_table, embedding_function=embeddings, distance_strategy=dist_strategy)

return knowledge_base