Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds Basic/simplified Resource Provider Code sample #404

Merged
merged 6 commits into from
Nov 6, 2024
Merged

Adds Basic/simplified Resource Provider Code sample #404

merged 6 commits into from
Nov 6, 2024

Conversation

aberinnj
Copy link
Contributor

No description provided.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Oct 25, 2024
@aberinnj
Copy link
Contributor Author

@Kuassim @jeandelavarene Please review, thank you

Kuassim
Kuassim suggested changes Oct 28, 2024
View reviewed changes
Copy link
Contributor

@Kuassim Kuassim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In Main.java
I saw a try-catch; why not use a try-with-resource (as in the comment)?
I also saw you are using DriverManager.getConnection instead of using
OracleDataSource ods = new OracleDataSource();
...
Connection conn = ods.getConnection()

@aberinnj
Copy link
Contributor Author

Ok fixed!

@gvenzl gvenzl requested a review from jeandelavarene October 29, 2024 18:50
jeandelavarene
jeandelavarene reviewed Nov 5, 2024
View reviewed changes
java/jdbc-resource-providers/README.md

### Example 1: OCI Connection TLS + OCI Connection String Providers

To run this example, in [main.java](src/main/java/org/oracle/Main.java), set the following environment variables
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aberinnj should we add some details about the feature? For example, explain what it does and when it should be used...

MouhsinElmajdouby
MouhsinElmajdouby reviewed Nov 5, 2024
View reviewed changes
@jeandelavarene jeandelavarene merged commit 264ea1c into oracle-samples:main Nov 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kuassim Kuassim Kuassim approved these changes

@jeandelavarene jeandelavarene jeandelavarene approved these changes

@MouhsinElmajdouby MouhsinElmajdouby MouhsinElmajdouby approved these changes

Assignees
No one assigned
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aberinnj @Kuassim @jeandelavarene @MouhsinElmajdouby