Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle extra space before equal sign #392

Merged
merged 3 commits into from
Sep 10, 2024

Conversation

ejannett
Copy link
Contributor

@ejannett ejannett commented Sep 9, 2024

391: Add handle of extra space before equal sign

Now the regexp matches

' or 'a'='a
' or 'a'= 'a
' or 'a' ='a
' or 'a' = 'a

391: Add handle of extra space before equal sign
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Sep 9, 2024
@@ -15,7 +15,7 @@
},
{
"className": "com.oracle.jdbc.samples.interceptor.rules.RegExpStatementRule",
"parameter": "(.|\\s)*(OR|or)\\s*('.*'|\\d*)=('.*'|\\d*)(.|\\s)*",
"parameter": "(.|\\s)*(OR|or)\\s*('.*'|\\d*)(.|\\s)*=('.*'|\\d*)(.|\\s)*",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this catch a space after the = sign and before the single quote?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,
See my next update, actually we need another update in an other file.

@jeandelavarene jeandelavarene merged commit 966a99f into oracle-samples:main Sep 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants