-
Notifications
You must be signed in to change notification settings - Fork 849
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code sample - 23c SpringBoot JPA Hibernate UCP #315
Code sample - 23c SpringBoot JPA Hibernate UCP #315
Conversation
74f5894
to
525af25
Compare
@Kuassim @jeandelavarene adjustments executed - indentation fixed. Please review and approve. Thanks. |
Hi @juarezjuniorgithub can you please use "23ai" instead of "23c" in this PR? Thanks. |
|
||
class EmployeeNotFoundException extends RuntimeException { | ||
|
||
private static final long serialVersionUID = 7768215094663842819L; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why the serialVersionUID?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed as requested. @Kuassim please approve, thanks
<dependency> | ||
<groupId>com.oracle.database.jdbc</groupId> | ||
<artifactId>ojdbc11-production</artifactId> | ||
<version>23.4.0.24.05</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please upgrade to 23.6.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Kuassim I have followed Jean's suggestion and updated the driver version to 23.6.0.24.10.
However, let's try to abide by our latest agreements, as asking recurrently to update the driver version before the very first release of a given code sample configures a dead-end situation, where it's being kept in a situation of open modification.
Such updates (versions/releases) will be done as part of our agreed Quarterly QA Freshness Pass activity.
@Kuassim please approve.
Code sample - 23c SpringBoot JPA Hibernate UCP
Signed-off-by: Juarez Barbosa juarez.barbosa@oracle.com