Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code sample - 23c with Spring Data JDBC #314

Merged

Conversation

juarezjuniorgithub
Copy link
Member

Code sample - 23c with Spring Data JDBC
Signed-off-by: Juarez Barbosa juarez.barbosa@oracle.com

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Jun 18, 2024
@juarezjuniorgithub
Copy link
Member Author

@Kuassim @jeandelavarene I performed the adjustments you requested - indentation fixed. Please approve, thanks.

@jeandelavarene
Copy link
Contributor

Can you please use 23ai instead of 23c?

@juarezjuniorgithub
Copy link
Member Author

updated to 23ai as requested. @Kuassim please review and approve. thanks

@jeandelavarene
Copy link
Contributor

@Kuassim can you please follow up with @juarezjuniorgithub to ensure that all PR mention 23ai, not 23c and use the latest RU, i.e. 23.6. Thanks.

@juarezjuniorgithub
Copy link
Member Author

juarezjuniorgithub commented Jan 31, 2025

@Kuassim @jeandelavarene as requested, updated to 23ai + driver 23.6.0.24.10 as requested, also updated to ucp17

Please approve, thanks. commit
ee339fa

@jeandelavarene
Copy link
Contributor

@juarezjuniorgithub please refresh your branch and update the PR.

@jeandelavarene jeandelavarene merged commit 0e1bbf5 into oracle-samples:main Jan 31, 2025
1 check passed
@juarezjuniorgithub
Copy link
Member Author

@jeandelavarene, it was not my branch but an upstream one. As we talked on Slack, I did it for us. Please approve. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants