Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added sample code - ODSA for Java Devs - Spring Boot 3 + Data JPA P2 #229

Merged
merged 10 commits into from
Nov 23, 2024
Merged

Added sample code - ODSA for Java Devs - Spring Boot 3 + Data JPA P2 #229

merged 10 commits into from
Nov 23, 2024

Conversation

juarezjuniorgithub
Copy link
Member

@Kuassim
Signed-off-by: Juarez Barbosa Junior juarez.barbosa@gmail.com

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Dec 5, 2022
gvenzl
gvenzl requested changes Dec 5, 2022
View reviewed changes
java/odsa-spring/src/main/resources/application.properties Outdated
Comment on lines 16 to 19
spring.jpa.show-sql=true
spring.jpa.properties.hibernate.format_sql=true
logging.level.org.hibernate.SQL=DEBUG
logging.level.org.hibernate.type.descriptor.sql.BasicBinder=TRACE
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really need debugging for a demo script? One would assume that a developer understands when/how to turn on debugging.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adjustment accepted, debugging properties removed. @Kuassim please review, thanks

@juarezjuniorgithub juarezjuniorgithub mentioned this pull request Dec 6, 2022
Open
@gvenzl gvenzl requested a review from jeandelavarene April 19, 2024 17:22
@juarezjuniorgithub
Copy link
Member Author

@Kuassim @jeandelavarene the changes were performed as required - fix indentation.
Please review, thanks.

jeandelavarene
jeandelavarene reviewed Nov 7, 2024
View reviewed changes
java/odsa-spring/src/main/java/com/oracle/dev/jdbc/odsa/spring/Employee.java Outdated
@@ -0,0 +1,118 @@
/*
Copyright (c) 2021, 2022, Oracle and/or its affiliates.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change year to 2024

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I did it for all classes with the license note and updated them to 2024 as you requested

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Kuassim please review, approve and notify Jean per the process (2nd level approval). Thanks!

jeandelavarene
jeandelavarene reviewed Nov 7, 2024
View reviewed changes
java/odsa-spring/src/main/java/com/oracle/dev/jdbc/odsa/spring/EmployeeNotFoundException.java Outdated

class EmployeeNotFoundException extends RuntimeException {

private static final long serialVersionUID = 7768215094663842819L;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check if this is needed.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Kuassim please review, approve and notify Jean per the process (2nd level approval). Thanks!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved; up to @jeandelavarene

@jeandelavarene
Copy link
Contributor

@juarezjuniorgithub please remove the target directory from your PR. You can add it to your .gitignore.
See this: https://stackoverflow.com/questions/991801/git-ignores-and-maven-targets
Also please upgrade the JDBC driver to 23.6.

@juarezjuniorgithub
Copy link
Member Author

Hi @Kuassim I have followed Jean's suggestion and updated the driver version to 23.6.0.24.10.
However, let's try to abide by our latest agreements, as asking recurrently to update the driver version before the
very first release of a given code sample configures a dead-end situation, where it's being kept in a situation of
open modification. Such updates (versions/releases) will be done as part of our agreed Quarterly QA Freshness Pass activity.
I have also addressed the issues with the /target directory as requested.
@Kuassim please approve. Thanks

jeandelavarene
jeandelavarene reviewed Nov 19, 2024
View reviewed changes
java/odsa-spring/README.md Outdated
@@ -0,0 +1,2 @@
# odsa-spring
[]()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The README should at least mention what this code sample is about.

@jeandelavarene jeandelavarene merged commit 73628a2 into oracle-samples:main Nov 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gvenzl gvenzl gvenzl approved these changes

@Kuassim Kuassim Kuassim approved these changes

@jeandelavarene jeandelavarene jeandelavarene approved these changes

Assignees
No one assigned
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@juarezjuniorgithub @jeandelavarene @gvenzl @Kuassim