Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid toggle password & confirm password as same time when one button is clicked #2223

Merged
merged 1 commit into from
May 29, 2022

Conversation

hishamco
Copy link
Contributor

No description provided.

@sbwalker
Copy link
Member

I do not understand the actual problem you are trying to fix with this PR? The current user experience is that when a user chooses the Show Password button it displays the values of the Password and Confirm fields. This is by design as the reason why a user would use the Show Password option in this specific scenario is because the passwords they entered do not match - which is a requirement for installation. So it makes no sense to make them click 2 separate buttons.

@hishamco
Copy link
Contributor Author

So it makes no sense to make them click 2 separate buttons.

If it's like that there's no need for two buttons, one button is enough. If you have a look to some browsers each password field has it's icon to hide / show the password

The actual issue is UI/UX why I should click any of the buttons to hide / show both password and confirm password

@sbwalker
Copy link
Member

Ok I understand your point... I will merge this PR

@sbwalker sbwalker merged commit 75ecae4 into oqtane:dev May 29, 2022
@hishamco hishamco deleted the toggle-password branch May 29, 2022 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants