added security attribute to TenantController Get methods and resolved TenantId on server during Installation #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sync with upstream
… TenantId on server during Installation
fileman
reviewed
Oct 24, 2019
| @@ -95,27 +95,29 @@ private Log ProcessStructuredLog(Log Log) | |||
| names.Add(message.Substring(index + 1, message.IndexOf("}", index) - index - 1)); | |||
| if (values.Length > (names.Count - 1)) | |||
| { | |||
| message = message.Replace("{" + names[names.Count - 1] + "}", values[names.Count - 1]?.ToString() ?? "null"); | |||
| if (values[names.Count - 1] == null) | |||
There was a problem hiding this comment.
Why you prefer an "IF" instead of "??" operator, readability or technical reason?
|
Good question. I prefer the longer conditional form for readability, debugging, and maintenance. If I am skimming a chunk of code it is really easy to follow the flow if you see standard if conditions - the shorter form is more concise but its really easy to miss the embedded conditional logic ( and not all developers are familiar with the shorter syntax - whereas all developers are familiar with the standard form ). That being said, I do use the shorte (rx == y) ? 1: 0; sometimes ( usually in very simplistic scenarios ) - so even I am not 100% consistent. |
|
ok, I will try to remember it for the next PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.