Added Keypress event to catch Enter key on Login page #1198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge pull request #1163 from leigh-pointer/dev
Merge all to master
align PRs from source to fork.main
Commits on Mar 12, 2021
Commits on Mar 25, 2021
|
Looks good but I'm not sure why there's 10 commits, can you rebase on |
…match any alias
After finish Edit, there's a class "container" which is conflict with Bootstrap that cause an issue on Full-width pane.
|
I think the No. of commits is too much according to what it needed, also I see some formatting has been added, the PR should be focus on what it should to make it easy to review Thanks |
|
@leigh-pointer could you resubmit this PR in a cleaner format so that it does not contain a lot of historical commits? |
sbwalker
added a commit
that referenced
this pull request
Apr 2, 2021
Added Keypress event to catch Enter key on Login page #1198
|
Closing this PR as it was replaced by #1216 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when the [Enter] key is press no action is carried out. This pull request sets the focus to the User Name field and when the [Enter] key is pressed the Login procedure is executed.