Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PWA question #1097

Closed
PhilipMur opened this issue Feb 9, 2021 · 7 comments
Closed

PWA question #1097

PhilipMur opened this issue Feb 9, 2021 · 7 comments

Comments

@PhilipMur
Copy link
Contributor

Hello,

Not sure where else I can find an answer to my question so I apologise if there is a forum somewhere else that I should post this question.

Just a question on adding to the Web app PWA functionality.

I can see in the >>admin dashboard >>site settings that there is a section "Progressive Web Application Settings".

If I set it up to be a PWA here are the files
manifest.json
service-worker.js
service-worker.published.js
wwwroot/index.html (link elemnts)
Etc...
Supposed to be added automatically or are they to be added manually?

Philip

@sbwalker
Copy link
Member

sbwalker commented Feb 9, 2021

If you enable a site to be available as a PWA and you provide an App and Splash icon, Oqtane will dynamically generate the manifest and automatically include the service worker.

@PhilipMur
Copy link
Contributor Author

Hello Shaun,

I have tried this in Debug mode, Release mode with no joy.

The files needed are not being automatically created.

I have uploaded an app icon 192x192.png and a splash icon 512x512.png and I have tried chrome, Edge, Firefox but still I don't get the little plus icon to install nor do I see the PWA files being created.

I'm using framework version 2.0.0 with Visual studio 2019

@PhilipMur
Copy link
Contributor Author

Here are the commercial free pictures used.
pie-icon-512
sphere-192

here is the on saved log.
PWA Log on save.txt

@PhilipMur PhilipMur changed the title Pwa question PWA question Feb 10, 2021
@PhilipMur
Copy link
Contributor Author

Also I have the app settings.json file "Runtime" : "WebAssembly"

Also the management panel will not display when the Runtime is set to WebAssembly as I was going to take a screenshot of the system info.

I have also tried in Debug and Release and published and different browsers and clear the cache etc.

@sbwalker
Copy link
Member

So I did some testing and there does seem to be an issue. The script and manifest are all being created and linked properly, however some of the Urls in the manifest appear to be relative when they need to be absolute. I am still exploring further to try and identify the PR that caused this issue.

The dynamic injection of the script and manifest makes it a bit tricky to understand - you need to use the browser debugging tools ( I use Firefox Developer Edition ):

image

image

sbwalker added a commit that referenced this issue Feb 10, 2021
fix #1097 - made PWA manifest Urls absolute rather than relative
@sbwalker
Copy link
Member

sbwalker commented Feb 10, 2021

Thank you for reporting this - it is fixed in #1098

image

@PhilipMur
Copy link
Contributor Author

Wow you don't waste anytime.

No problem, glad I can help in some way.
Web development is not my strong point at the moment but this framework definitely speeds up the learning curve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants