refactor: self review refactor

opynfinance · Feb 8, 2023 · 7de006e · 7de006e
1 parent e4f30ec
commit 7de006e
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/packages/frontend/src/components/Strategies/Bull/BullTrade/Deposit.tsx b/packages/frontend/src/components/Strategies/Bull/BullTrade/Deposit.tsx
@@ -238,15 +238,15 @@ const BullDeposit: React.FC<{ onTxnConfirm: (txn: BullTransactionConfirmation) =
       }
 
       if (useQueue) {
-        await queueDepositEth(new BigNumber(depositAmountRef.current), dataToTrack, onTxnConfirmed)
+        await queueDepositEth(amount, dataToTrack, onTxnConfirmed)
       } else {
         await bullFlashDeposit(
           quote.ethToCrab,
           quote.minEthFromSqth,
           quote.minEthFromUsdc,
           quote.wPowerPerpPoolFee,
           quote.usdcPoolFee,
-          new BigNumber(depositAmountRef.current),
+          amount,
           dataToTrack,
           onTxnConfirmed,
         )

diff --git a/packages/frontend/src/pages/positions/BullPosition.tsx b/packages/frontend/src/pages/positions/BullPosition.tsx
@@ -38,13 +38,13 @@ const BullPosition: React.FC = () => {
 
   const loading = !useAtomValue(bullPositionLoadedAtom)
 
-  const initiatedDepositAmount = toTokenAmount(ethQueued, WETH_DECIMALS)
-  const initiatedWithdrawalAmount = toTokenAmount(zenBullQueued, ZENBULL_TOKEN_DECIMALS).times(bullEthValue)
-
-  if (bullCurrentETH.isZero() && initiatedDepositAmount.isZero() && initiatedWithdrawalAmount.isZero()) {
+  if (bullCurrentETH.isZero() && ethQueued.isZero() && zenBullQueued.isZero()) {
     return null
   }
 
+  const initiatedDepositAmount = toTokenAmount(ethQueued, WETH_DECIMALS)
+  const initiatedWithdrawalAmount = toTokenAmount(zenBullQueued, ZENBULL_TOKEN_DECIMALS).times(bullEthValue)
+
   return (
     <div className={classes.position} id="pos-page-bull">
       <div className={classes.positionTitle}>