Skip to content

add identifiers #339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

add identifiers #339

wants to merge 1 commit into from

Conversation

Mat001
Copy link
Contributor

@Mat001 Mat001 commented Sep 29, 2023

Summary

Details from the original PR:

  • Include object id/key in errors when objects not found in datafile
  • Modifies invalid object id/key log messages to make them consistent

Include object id/key in errors when an object is not found makes them available to the user or the custom error handler.

One example of why this is useful is that the key of an experiment could be used within a custom error handler to fetch the details of the experiment. This would indicate whether the experiment has been paused (in which case the error could be ignored) or archived (in which case the code referencing the experiment should be removed from the application).

This change will impact existing custom error handlers which are expecting an error class rather than an error object instance.

Test plan

Jira ticket:
https://jira.sso.episerver.net/browse/FSSDK-9439

@Mat001 Mat001 requested a review from a team as a code owner September 29, 2023 03:26
@Mat001 Mat001 self-assigned this Sep 29, 2023
@Mat001 Mat001 requested a review from jaeopt September 29, 2023 03:39
@Mat001
Copy link
Contributor Author

Mat001 commented Sep 29, 2023

@jaeopt Can you please approve this? Andy already approved, It's a copy of the original PR to be able to test FSC and integration tests.

@andrewleap-optimizely
Copy link
Contributor

This was merged via #301

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants