Skip to content

[FSSDK-9130] fix: invalid identifier error code #335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 25, 2023
Merged

[FSSDK-9130] fix: invalid identifier error code #335

merged 2 commits into from
Apr 25, 2023

Conversation

andrewleap-optimizely
Copy link
Contributor

Summary

  • Aligned with error code used by ODP

Test plan

all tests should pass

Ticket

FSSDK-9130

@andrewleap-optimizely andrewleap-optimizely marked this pull request as ready for review April 21, 2023 18:44
@andrewleap-optimizely andrewleap-optimizely requested a review from a team as a code owner April 21, 2023 18:44
jaeopt
jaeopt requested changes Apr 21, 2023
View reviewed changes
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Suggest to use standard error messages

Mat001
Mat001 approved these changes Apr 24, 2023
View reviewed changes
Copy link
Contributor

@Mat001 Mat001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks ok

jaeopt
jaeopt approved these changes Apr 24, 2023
View reviewed changes
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewleap-optimizely andrewleap-optimizely merged commit 016fbb5 into master Apr 25, 2023
@andrewleap-optimizely andrewleap-optimizely deleted the aleap/fix_odp_invalid_response branch April 25, 2023 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mat001 Mat001 Mat001 approved these changes

@jaeopt jaeopt jaeopt approved these changes

Assignees

@andrewleap-optimizely andrewleap-optimizely

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrewleap-optimizely @Mat001 @jaeopt