feat: update ruby version #305
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aleap/update_ruby_version
zashraf1985
suggested changes
Aug 2, 2022
| @@ -34,7 +34,8 @@ class SimpleLogger < BaseLogger | |||
| # Simple wrapper around Logger. | |||
|
|
|||
| def initialize(min_level = Logger::INFO) | |||
| @logger = Logger.new(STDOUT) | |||
| super() | |||
| @logger = Logger.new($stdout) | |||
There was a problem hiding this comment.
Is $stdout supposed to be defined somewhere above?
There was a problem hiding this comment.
This was one of the automated fixes generated by rubocop. Looks like both STDOUT and $stdout have global scope, but $stdout is preferred because STDOUT is a constant.
lib/optimizely/version.rb
Outdated
| @@ -17,5 +17,5 @@ | |||
| # | |||
| module Optimizely | |||
| CLIENT_ENGINE = 'ruby-sdk' | |||
| VERSION = '3.10.1' | |||
| VERSION = '4.0.0' | |||
There was a problem hiding this comment.
We only update version when we are making a PR for release prep. you should leave the SDK version as is for this PR
zashraf1985
suggested changes
Aug 3, 2022
CHANGELOG.md
Outdated
| @@ -1,7 +1,7 @@ | |||
| # Optimizely Ruby SDK Changelog | |||
|
|
|||
| ## 4.0.0 | |||
| August 1st, 2022 | |||
| August 3st, 2022 | |||
There was a problem hiding this comment.
No need to add a date and version here. Version and date will be added once we are ready to release. This should go in unreleased. It should be
Unreleased
Changes
- Breaking change: Changed official supported versions of Ruby to 2.7, 3.0 and 3.1
lib/optimizely/optimizely_config.rb
Outdated
| @@ -1,6 +1,6 @@ | |||
| # frozen_string_literal: true | |||
|
|
|||
| # Copyright 2019-2021, Optimizely and contributors | |||
| # Copyright 2019-2021, 2022, Optimizely and contributors | |||
There was a problem hiding this comment.
this should be 2019-2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Current supported versions have reached EOL.
Test plan
Ticket