-
Notifications
You must be signed in to change notification settings - Fork 28
feat(OptimizelyConfig): Add new fields to OptimizelyConfig #285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
06ba039
init
ozayr-zaviar 61706dc
experiment and delivery rules implemented
ozayr-zaviar f065fa4
rubocop error fixed
ozayr-zaviar 2099a46
variable name corrected
ozayr-zaviar 9fa1c8c
syntax error fixed
ozayr-zaviar 9c25e55
testapp creash case fixed
ozayr-zaviar 5e89329
FSC test cases fixed
ozayr-zaviar 7101864
refactoring
ozayr-zaviar e9bfc9a
comments addressed
ozayr-zaviar f8843dd
unit tests added
ozayr-zaviar d3ac144
comments addressed and unit test for audiences added
ozayr-zaviar c9fd3fe
rollout condition added
ozayr-zaviar 50ed1fd
experiment in rollout fucntion added
ozayr-zaviar f3f9cae
no need to check featureEnabled.
msohailhussain fe21ff7
Merge branch 'master' into uzair/opt-config-v2
msohailhussain 8938534
comments addressed
ozayr-zaviar a12b39e
unit test fixed
ozayr-zaviar 94ca43d
comments addressed
ozayr-zaviar e6b1e8d
rollout experiment unit test added
ozayr-zaviar eb45b1a
depreciation comments added
ozayr-zaviar 4edf298
rephrased comment.
msohailhussain File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
depreciation comments added
- Loading branch information
commit eb45b1a8cc7fd7a6a2074aa3cb552c557e3896e4
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This message should be chanaged to:
"This experimentsMap is deprecated. Use experimentRules and deliveryRules instead."
The one at top level ("experimentsMap" in OptimizleyConfig) looks good.