feat(Decide): Add Optimizely User Context #273
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oakbani
changed the title
jaeopt
requested changes
Oct 28, 2020
Contributor
jaeopt
left a comment
jaeopt
left a comment
There was a problem hiding this comment.
Looks good except for questions about concurrency support.
| expected_attributes['browser'] = 'chrome' | ||
|
|
||
| expect(user_context_obj.instance_variable_get(:@user_attributes)). to eq(expected_attributes) | ||
| end |
Contributor
There was a problem hiding this comment.
Can we add a test - when the caller change its attribute copy after userContext is created, it should not be reflected to userContext?
| def initialize(optimizely_client, user_id, user_attributes) | ||
| @optimizely_client = optimizely_client | ||
| @user_id = user_id | ||
| @user_attributes = user_attributes |
Contributor
There was a problem hiding this comment.
Does this create a copy of the passed user_attributes, so it's not reflected when the client copy is changed later?
| end | ||
|
|
||
| def set_attribute(attribute_key, attribute_value) | ||
| @user_attributes[attribute_key] = attribute_value |
Contributor
There was a problem hiding this comment.
"set_attribute" can be called concurrently with get-attributes from the userContext. Don't we need to synchronization for attributes read/write?
Contributor
Author
|
Closing in favour of #274 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is the first PR for Decide API.
This PR adds
Test plan
Added Unit tests.