fix(config-manager): Fixes polling interval and blocking timeout issues #187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 similar comment
mikeproeng37
suggested changes
Jul 25, 2019
| if polling_interval.nil? | ||
| @logger.log( | ||
| Logger::DEBUG, | ||
| "Polling interval is not given. Defaulting to #{Helpers::Constants::CONFIG_MANAGER['DEFAULT_UPDATE_INTERVAL']}." |
There was a problem hiding this comment.
Nit: ... not provided
| @polling_interval = Helpers::Constants::CONFIG_MANAGER['DEFAULT_UPDATE_INTERVAL'] | ||
| unless polling_interval.is_a? Integer | ||
| @logger.log( | ||
| Logger::DEBUG, |
There was a problem hiding this comment.
This and the next lot should be error level logs
|
|
||
| unless blocking_timeout.is_a? Integer | ||
| @logger.log( | ||
| Logger::DEBUG, |
There was a problem hiding this comment.
Same thing regarding error level logs
mikeproeng37
approved these changes
Jul 25, 2019
| unless polling_interval.between?(Helpers::Constants::CONFIG_MANAGER['MIN_SECONDS_LIMIT'], Helpers::Constants::CONFIG_MANAGER['MAX_SECONDS_LIMIT']) | ||
| @logger.log( | ||
| Logger::DEBUG, | ||
| "Polling interval '#{polling_interval}' has invalid range. Defaulting to #{Helpers::Constants::CONFIG_MANAGER['DEFAULT_UPDATE_INTERVAL']}." |
There was a problem hiding this comment.
measurement unit would be good for all logs
Defaulting to #{Helpers::Constants::CONFIG_MANAGER['DEFAULT_UPDATE_INTERVAL']}. seconds
There was a problem hiding this comment.
Yep we should specify the unit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test plan