Skip to content

(feat): Implements ProjectConfig interface and creates DatafileProjectConfig. #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 27, 2019
Merged

(feat): Implements ProjectConfig interface and creates DatafileProjectConfig. #177

merged 2 commits into from
Jun 27, 2019

Conversation

@rashidsp
Copy link
Contributor

@rashidsp rashidsp commented Jun 26, 2019 •
edited
Loading

Summary

  • Implemented ProjectConfig interface and created DatafileProjectConfig.
  • Removed logger from config object; Passed separately in user_in_experiment? method.
  • Updated related unit tests

@coveralls
Copy link

coveralls commented Jun 26, 2019

Coverage Status

Coverage increased (+0.001%) to 99.87% when pulling 0f25d95 on rashid/project-config-interface into e29462f on master.

1 similar comment
@coveralls
Copy link

coveralls commented Jun 26, 2019

Coverage Status

Coverage increased (+0.001%) to 99.87% when pulling 0f25d95 on rashid/project-config-interface into e29462f on master.

@coveralls
Copy link

coveralls commented Jun 26, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.001%) to 99.87% when pulling a28fbc2 on rashid/project-config-interface into e29462f on master.

@rashidsp rashidsp requested review from a team and msohailhussain June 26, 2019 19:02
mikeproeng37
mikeproeng37 approved these changes Jun 27, 2019
View reviewed changes
Copy link
Contributor

@mikeproeng37 mikeproeng37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mikeproeng37 mikeproeng37 merged commit ccacb22 into master Jun 27, 2019
@oakbani oakbani deleted the rashid/project-config-interface branch June 28, 2019 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@msohailhussain msohailhussain Awaiting requested review from msohailhussain

1 more reviewer

@mikeproeng37 mikeproeng37 mikeproeng37 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rashidsp @coveralls @mikeproeng37